From 1ac4b71595cb23b7b9a547b76325ca8ff52a3df3 Mon Sep 17 00:00:00 2001 From: maikkeli Date: Thu, 28 Jan 2016 13:39:05 +1030 Subject: [PATCH] remove unnecessary cachebreaking, change comments --- Dockerfile | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index abc0e8a..59d322f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -38,21 +38,20 @@ RUN apt-get install -y \ # Install LedgerSMB WORKDIR /srv -# update the following label to force docker to cache the latest git clone: -LABEL lsmb_docker_git_clone_cachebreak=2016-01-28 + RUN git clone https://github.com/ledgersmb/LedgerSMB.git ledgersmb # Set LedgerSMB version (git tag/branch/commit) -# Change the following line or set arg on docker build commandline; +# Change LSMB_VERSION or use --build-arg on docker build commandline; # eg: -# docker build --build-arg LSMB_VERSION=1.4.0 ./ -# docker build --build-arg LSMB_VERSION=1c00d61 ./ -# NOTE: if you use a branch name (or a reused tag name) instead of a commit checksum +# docker build --build-arg LSMB_VERSION=1.5.0-beta3 . +# docker build --build-arg LSMB_VERSION=1c00d61 . +# NOTE: If you use a branch name (or a reused tag name) instead of a commit checksum # then docker's caching will see nothing new and you'll end up with stale files # if that branch/tag has already been cached. # -# As a hack to reliably use a branch (eg, master), try the following: -# docker build --build-arg CACHEBREAK="$(date)" --build-arg LSMB_VERSION=master ./ +# As a hack to reliably update a branch (eg, master), --build-arg CACHEBREAK="$(date)": +# eg: docker build --build-arg CACHEBREAK="$(date)" --build-arg LSMB_VERSION=master . ARG CACHEBREAK ARG LSMB_VERSION=1.5.0-beta3 ENV LSMB_VERSION ${LSMB_VERSION}