* Automatic Dockerfile update by release process

We've seen multiple users thinking that simple creation of two containers
is enough, whereas this isn't the case: at the very least, the deprecated
`--link` docker option must be used, but more compliant is the use of
custom networks and bridges. Docker-compose sets all that up automatically,
so don't suggest going without docker-compose is simpler.

Dockerfile

@@ -1,11 +1,13 @@
 # Build time variables
 
-ARG SRCIMAGE=debian:trixie-slim
+ARG SRCIMAGE=debian:stretch-slim
 
 
 FROM  $SRCIMAGE AS builder
 
-ENV LSMB_VERSION=master
+ARG LSMB_VERSION="1.7.40"
+ARG LSMB_DL_DIR="Releases"
+ARG ARTIFACT_LOCATION="https://download.ledgersmb.org/f/$LSMB_DL_DIR/$LSMB_VERSION/ledgersmb-$LSMB_VERSION.tar.gz"
 
 
 RUN set -x ; \
@@ -15,9 +17,10 @@ RUN set -x ; \
   apt-file update
 
 RUN set -x ; \
-  cd /srv && \
-  git clone --depth 1 --recursive -b $LSMB_VERSION https://github.com/ledgersmb/LedgerSMB.git ledgersmb && \
-  cd ledgersmb && \
+  wget --quiet -O /tmp/ledgersmb-$LSMB_VERSION.tar.gz "$ARTIFACT_LOCATION" && \
+  tar -xzf /tmp/ledgersmb-$LSMB_VERSION.tar.gz --directory /srv && \
+  rm -f /tmp/ledgersmb-$LSMB_VERSION.tar.gz && \
+  cd /srv/ledgersmb && \
   ( ( for lib in $( cpanfile-dump --with-all-features --recommends --no-configure --no-build --no-test ) ; \
     do \
       if dh-make-perl locate "$lib" 2>/dev/null ; \
@@ -38,97 +41,93 @@ RUN set -x ; \
 
 
 FROM  $SRCIMAGE
-LABEL   org.opencontainers.image.authors="LedgerSMB project <devel@lists.ledgersmb.org>"
-
-# Install Perl, Tex, Starman, psql client, and all dependencies
-#
-# Without libclass-c3-xs-perl, everything grinds to a halt;
-# add it, because it's a 'recommends' it the dep tree, which
-# we're skipping, normally
-#
-# Installing psql client directly from instructions at https://wiki.postgresql.org/wiki/Apt
-# That mitigates issues where the PG instance is running a newer version than this container
-
-COPY --from=builder /srv/derived-deps /tmp/derived-deps
-
-
-RUN set -x ; \
-  echo "APT::Install-Recommends \"false\";\nAPT::Install-Suggests \"false\";\n" > /etc/apt/apt.conf.d/00recommends && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y update && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y upgrade && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y install \
-    wget ca-certificates gnupg \
-    $( cat /tmp/derived-deps ) \
-    libclass-c3-xs-perl \
-    texlive-plain-generic texlive-latex-recommended texlive-fonts-recommended \
-    texlive-xetex fonts-liberation \
-    lsb-release && \
-  echo "deb [signed-by=/etc/apt/keyrings/postgresql.asc] http://apt.postgresql.org/pub/repos/apt/ $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list && \
-  wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc > /etc/apt/keyrings/postgresql.asc && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y update && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y install postgresql-client && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y autoremove && \
-  DEBIAN_FRONTEND="noninteractive" apt-get -y autoclean && \
-  rm -rf /var/lib/apt/lists/*
+MAINTAINER  Freelock john@freelock.com
 
 
 # Build time variables
-ENV LSMB_VERSION=master
-ENV NODE_PATH=/usr/local/lib/node_modules
+ARG LSMB_VERSION="1.7.40"
+ARG LSMB_DL_DIR="Releases"
+ARG ARTIFACT_LOCATION="https://download.ledgersmb.org/f/$LSMB_DL_DIR/$LSMB_VERSION/ledgersmb-$LSMB_VERSION.tar.gz"
+
+# Install Perl, Tex, Starman, psql client, and all dependencies
+# Without libclass-c3-xs-perl, performance is terribly slow...
+# Without libclass-accessor-lite-perl, HTML::Entities won't build from CPAN
+# libnet-cidr-lite-perl is a dependency for Plack::Builder::Conditionals
+#   which is being installed from CPAN
+# libtest-requires-perl is a dependency of Module-Build-Pluggable-PPPort
+#   on which HTML::Escape depends
+
+# Installing psql client directly from instructions at https://wiki.postgresql.org/wiki/Apt
+# That mitigates issues where the PG instance is running a newer version than this container
 
 
-###########################################################
-# Java & Nodejs for doing Dojo build
+COPY --from=builder /srv/derived-deps /tmp/derived-deps
 
-# These packages are only needed during the dojo build
-ENV DOJO_Build_Deps="git make gcc libperl-dev curl nodejs npm cpanminus"
-# These packages can be removed after the dojo build
-ENV DOJO_Build_Deps_removal="${DOJO_Build_Deps} nodejs npm cpanminus"
+RUN set -x ; \
+  echo -n "APT::Install-Recommends \"0\";\nAPT::Install-Suggests \"0\";\n" >> /etc/apt/apt.conf && \
+  mkdir -p /usr/share/man/man1/ && \
+  mkdir -p /usr/share/man/man2/ && \
+  mkdir -p /usr/share/man/man3/ && \
+  mkdir -p /usr/share/man/man4/ && \
+  mkdir -p /usr/share/man/man5/ && \
+  mkdir -p /usr/share/man/man6/ && \
+  mkdir -p /usr/share/man/man7/ && \
+  DEBIAN_FRONTEND="noninteractive" apt-get update -q && \
+  DEBIAN_FRONTEND="noninteractive" apt-get dist-upgrade -y -q && \
+  DEBIAN_FRONTEND="noninteractive" apt-get -y -q install \
+    wget ca-certificates gnupg \
+    $( cat /tmp/derived-deps ) \
+    libclass-c3-xs-perl libclass-accessor-lite-perl \
+    texlive-latex-recommended texlive-fonts-recommended \
+    texlive-xetex fonts-liberation \
+    ssmtp \
+    lsb-release && \
+  echo "deb http://apt.postgresql.org/pub/repos/apt/ $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list && \
+  (wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -) && \
+  DEBIAN_FRONTEND="noninteractive" apt-get -q -y update && \
+  DEBIAN_FRONTEND="noninteractive" apt-get -q -y install postgresql-client && \
+  DEBIAN_FRONTEND="noninteractive" apt-get -q -y install git cpanminus make gcc libperl-dev && \
+  wget --quiet -O /tmp/ledgersmb-$LSMB_VERSION.tar.gz "$ARTIFACT_LOCATION" && \
+  tar -xzf /tmp/ledgersmb-$LSMB_VERSION.tar.gz --directory /srv && \
+  rm -f /tmp/ledgersmb-$LSMB_VERSION.tar.gz && \
+  cpanm --notest \
+    --with-feature=starman \
+    --with-feature=latex-pdf-ps \
+    --with-feature=openoffice \
+    --installdeps /srv/ledgersmb/ && \
+  apt-get purge -q -y git cpanminus make gcc libperl-dev && \
+  apt-get autoremove -q -y && \
+  apt-get autoclean -q && \
+  rm -rf ~/.cpanm/ && \
+  rm -rf /var/lib/apt/lists/* /usr/share/man/*
 
-# RUN (wget --quiet -O - https://deb.nodesource.com/setup_22.x | bash -) && \
-RUN    DEBIAN_FRONTEND="noninteractive" apt-get -y update && \
-    DEBIAN_FRONTEND="noninteractive" apt-get -y install ${DOJO_Build_Deps} && \
-    npm i -g --no-save yarn && \
-    cd /srv && \
-    git clone --depth 1 --recursive -b $LSMB_VERSION https://github.com/ledgersmb/LedgerSMB.git ledgersmb && \
-    cd ledgersmb && \
-    cpanm --metacpan --quiet --notest \
-      --with-feature=starman \
-      --with-feature=latex-pdf-ps \
-      --with-feature=openoffice \
-      --installdeps .  && \
-    make js && \
-    DEBIAN_FRONTEND="noninteractive" apt-get -y purge ${DOJO_Build_Deps_removal} && \
-    rm -rf /usr/local/lib/node_modules && \
-    DEBIAN_FRONTEND="noninteractive" apt-get -y autoremove && \
-    DEBIAN_FRONTEND="noninteractive" apt-get -y autoclean && \
-    rm -rf ~/.cpanm && \
-    rm -rf /var/lib/apt/lists/*
 
-# Cleanup args that are for internal use
-ENV DOJO_Build_Deps=
-ENV DOJO_Build_Deps_removal=
-ENV NODE_PATH=
+WORKDIR /srv/ledgersmb
+
+# master requirements
 
 # Configure outgoing mail to use host, other run time variable defaults
 
-## MAIL
-ENV LSMB_MAIL_SMTPHOST=172.17.0.1
-#ENV LSMB_MAIL_SMTPPORT=25
-#ENV LSMB_MAIL_SMTPSENDER_HOSTNAME=(container hostname)
-#ENV LSMB_MAIL_SMTPTLS=
-#ENV LSMB_MAIL_SMTPUSER=
-#ENV LSMB_MAIL_SMTPPASS=
-#ENV LSMB_MAIL_SMTPAUTHMECH=
+## sSMTP
+ENV SSMTP_ROOT ar@example.com
+ENV SSMTP_MAILHUB 172.17.0.1
+ENV SSMTP_HOSTNAME 172.17.0.1
+#ENV SSMTP_USE_STARTTLS
+#ENV SSMTP_AUTH_USER
+#ENV SSMTP_AUTH_PASS
+ENV SSMTP_FROMLINE_OVERRIDE YES
+#ENV SSMTP_AUTH_METHOD
 
-ENV POSTGRES_HOST=postgres
-ENV POSTGRES_PORT=5432
-ENV DEFAULT_DB=lsmb
+ENV POSTGRES_HOST postgres
+ENV POSTGRES_PORT 5432
+ENV DEFAULT_DB lsmb
 
 COPY start.sh /usr/local/bin/start.sh
+COPY update_ssmtp.sh /usr/local/bin/update_ssmtp.sh
 
-RUN chmod +x /usr/local/bin/start.sh && \
-    mkdir -p /var/www
+RUN chown www-data /etc/ssmtp /etc/ssmtp/ssmtp.conf && \
+  chmod +x /usr/local/bin/update_ssmtp.sh /usr/local/bin/start.sh && \
+  mkdir -p /var/www
 
 # Work around an aufs bug related to directory permissions:
 RUN mkdir -p /tmp && \

README.md

@@ -4,16 +4,11 @@ Dockerfile for LedgerSMB Docker image
 
 # Supported tags
 
-- `1.13`, `1.13.x`, `latest` - Latest official release from the 1.13 branch
-- `1.12`, `1.12.x` - Latest official release from the 1.12 branch
-- `1.11`, `1.11.x` - Latest official release from the 1.11 branch
-- `1.10`, `1.10.38` - Last official release from the 1.10 branch
-- `1.9`, `1.9.30` - Last official release from 1.9 branch (End-of-Life)
-- `1.8`, `1.8.31` - Last official release from 1.8 branch (End-of-Life)
-- `1.7`, `1.7.41` - Last official release from 1.7 branch (End-of-Life)
-- `1.6`, `1.6.33` - Last official release from 1.6 branch (End-of-Life)
-- `1.5`, `1.5.30` - Last official release from 1.5 branch (End-of-Life)
-- `1.4`, `1.4.42` - Last official release from 1.4 branch (End-of-Life)
+- `1.8` - Preview version for the 1.8 branch
+- `1.7`, `1.7.x`, `latest` - Latest official release from 1.7 branch
+- `1.6`, `1.6.33` - Last official release from 1.6 branch 
+- `1.5`, `1.5.30` - Last official release from 1.5 branch
+- `1.4`, `1.4.42` - Last official release from 1.4 branch
 - `master` - Master branch from git, unstable
 
 Containers supporting the development process are provided
@@ -34,9 +29,9 @@ This image is designed to be used in conjunction with a running PostgreSQL
 instance (such as may be provided through a separate image).
 
 This image exposes port 5762 running a Starman HTTP application server. We
-do not recommend exposing this port publicly, because
+do recommend not exposing this port publicly, because
 
-1. The Starman author recommends it
+1. The Starman author recommends not exposing it
 2. We strongly recommend TLS encryption of all application traffic
 
 While the exposed port can be used for quick evaluation, it's recommended
@@ -48,10 +43,7 @@ could require additional setup of a mail service or CUPS printer service.
 # How to use this image
 
 This image can be installed either automatically with the Docker compose file
-manually with docker only.
-
-❌ Do not use unofficial or AI-generated Docker Compose examples. These are 
-often incomplete, break silently, or skip required services.
+or manually with docker only.
 
 ## Docker-Compose installation and start
 
@@ -78,6 +70,9 @@ The database username and password are:
    password: abc
 ```
 
+From here, follow the steps as detailed in the instructions for
+[preparing for first use](https://ledgersmb.org/content/preparing-ledgersmb-17-first-use).
+
 ## Manual installation
 
 This section assumes availability of a PostgreSQL server to attach to the

docker-compose.yml

@@ -16,7 +16,7 @@ services:
   # because that allows us to use the default hostname ("postgres")
   # from the LedgerSMB configuration
   postgres:
-    image: postgres:14-alpine
+    image: postgres:9.6-alpine
     environment:
       # Replace the password below for a secure setup
       POSTGRES_PASSWORD: abc
@@ -28,18 +28,12 @@ services:
   lsmb:
     depends_on:
       - postgres
-    image: ghcr.io/ledgersmb/ledgersmb:master
+    image: ghcr.io/ledgersmb/ledgersmb:1.7
     networks:
       - internal
       - default
-    # Uncomment the 'ports' section to map the LedgerSMB container port (5762)
-    #  to the host's port of the same number, thus making LedgerSMB
-    #  available on http://<host-dns-or-ip>:5762/
-    #     SECURITY NOTE: Do this for evaluation purposes only!
-    #       In production, be sure to use SSL/TLS to protect user's passwords
-    #       and other sensitive data
-    # ports:
-    #   - "5762:5762"
+    ports:
+      - "127.0.0.1:5762:5762"
     environment:
       # The LSMB_WORKERS environment variable lets you select the number
       # of processes serving HTTP requests. The default number of 2 workers

start.sh

@@ -1,85 +1,8 @@
 #!/bin/bash
 
+update_ssmtp.sh
 cd /srv/ledgersmb
 
-if [[ -n "$SSMTP_ROOT" ]]; then
-    echo "\$SSMTP_ROOT set; parameter is deprecated and will be ignored"
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_FROMLINE_OVERRIDE" ]]; then
-    echo "\$SSMTP_FROMLINE_OVERRIDE set; parameter is deprecated and will be ignored"
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_MAILHUB" ]]; then
-    echo "\$SSMTP_MAILHUB set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPHOST" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPHOST setting from \$SSMTP_MAILHUB"
-        LSMB_MAIL_SMTPHOST=${SSMTP_MAILHUB%:*}
-    fi
-    if [[ -z "$LSMB_MAIL_SMTPPORT" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPPORT setting from \$SSMTP_MAILHUB"
-        LSMB_MAIL_SMTPPORT=${SSMTP_MAILHUB#*:}
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_HOSTNAME" ]]; then
-    echo "\$SSMTP_HOSTNAME set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPSENDER_HOSTNAME" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPSENDER_HOSTNAME setting from \$SSMTP_HOSTNAME"
-        LSMB_MAIL_SMTPSENDER_HOSTNAME=$SSMTP_HOSTNAME
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_USE_STARTTLS" ]]; then
-    echo "\$SSMTP_USE_STARTTLS set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPTLS" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPSENDER_HOSTNAME setting from \$SSMTP_USE_STARTTLS"
-        LSMB_MAIL_SMTPTLS=$SSMTP_USE_STARTTLS
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_AUTH_USER" ]]; then
-    echo "\$SSMTP_AUTH_USER set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPUSER" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPUSER setting from \$SSMTP_AUTH_USER"
-        LSMB_MAIL_SMTPUSER=$SSMTP_AUTH_USER
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_AUTH_PASS" ]]; then
-    echo "\$SSMTP_AUTH_PASS set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPPASS" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPPASS setting from \$SSMTP_AUTH_PASS"
-        LSMB_MAIL_SMTPPASS=$SSMTP_AUTH_PASS
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-if [[ -n "$SSMTP_AUTH_METHOD" ]]; then
-    echo "\$SSMTP_AUTH_METHOD set; parameter is deprecated"
-    if [[ -z "$LSMB_MAIL_SMTPAUTHMECH" ]]; then
-        echo "  Deriving \$LSMB_MAIL_SMTPAUTHMECH setting from \$SSMTP_AUTH_METHOD"
-        LSMB_MAIL_SMTPAUTHMECH=$SSMTP_AUTH_METHOD
-    fi
-    LSMB_HAVE_DEPRECATED=1
-fi
-
-if [[ -n "$LSMB_HAVE_DEPRECATED" ]]; then
-    echo "!!! DEPRECATED \$SSMTP_* PARAMETERS WILL BE REMOVED in the 1.9 image!!!"
-fi
-# This was never a parameter: ?
-# if [[ -n "$SSMTP_USE_TLS" ]]; then
-#     echo "\$SSMTP_USE_TLS set; parameter is deprecated"
-#     if [[ -z "$LSMB_MAIL_SMTPTLS" ]]; then
-#         echo "  Deriving \$LSMB_MAIL_SMTPSENDER_HOSTNAME setting from \$SSMTP_MAILHUB"
-#         if [[ "$SSMTP_USE_TLS" == "yes" ]]; then
-#             LSMB_MAIL_SMTPTLS=raw
-#         else
-#             LSMB_MAIL_SMTPTLS=no
-#         fi
-#     fi
-# fi
-
-
 if [[ ! -f ledgersmb.conf ]]; then
   cat <<EOF >/tmp/ledgersmb.conf
 [main]
@@ -91,14 +14,7 @@ port = $POSTGRES_PORT
 default_db = $DEFAULT_DB
 
 [mail]
-${LSMB_MAIL_SMTPHOST:+smtphost=$LSMB_MAIL_SMTPHOST
-}${LSMB_MAIL_SMTPPORT:+smtpport=$LSMB_MAIL_SMTPPORT
-}${LSMB_MAIL_SMTPSENDER_HOSTNAME:+smtpsender_hostname=$LSMB_MAIL_SMTPSENDER_HOSTNAME
-}${LSMB_MAIL_SMTPTLS:+smtptls=$LSMB_MAIL_SMTPTLS
-}${LSMB_MAIL_SMTPUSER:+smtpuser=$LSMB_MAIL_SMTPUSER
-}${LSMB_MAIL_SMTPPASS:+smtppass=$LSMB_MAIL_SMTPPASS
-}${LSMB_MAIL_SMTPAUTHMECH:+smtpauthmech=$LSMB_MAIL_SMTPAUTHMECH
-}
+sendmail   = /usr/sbin/ssmtp
 
 [proxy]
 ip=${PROXY_IP:-172.17.0.1/12}
@@ -106,24 +22,14 @@ EOF
   export LSMB_CONFIG_FILE='/tmp/ledgersmb.conf'
 fi
 
-# Currently unmaintained/untested
-# if [ ! -z ${CREATE_DATABASE+x} ]; then
-#   perl tools/dbsetup.pl --company $CREATE_DATABASE \
-#   --host $POSTGRES_HOST \
-#   --postgres_password "$POSTGRES_PASS"
-#fi
+if [ ! -d "/tmp/ledgersmb" ]; then
+  mkdir -p /tmp/ledgersmb
+fi
 
 # start ledgersmb
 # --preload-app allows application initialization to kill the entire
 # starman instance (instead of just the worker, which will immediately
 # get restarted); it also has a positive effect on memory use
 
-echo '--------- LEDGERSMB CONFIGURATION:  ledgersmb.conf'
-cat ${LSMB_CONFIG_FILE:-ledgersmb.conf}
-echo '--------- LEDGERSMB CONFIGURATION --- END'
-
-# ':5762:' suppresses an uninitialized variable warning in starman
-# the last colon means "don't connect using tls"; without it, there's a warning
-exec starman --listen :5762: --workers ${LSMB_WORKERS:-5} \
-             -I lib -I old/lib \
-             --preload-app bin/ledgersmb-server.psgi
+exec starman --port 5762 --workers ${LSMB_WORKERS:-5} -I lib -I old/lib \
+        --preload-app bin/ledgersmb-server.psgi

update_ssmtp.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+ConfiguredComment='# install script update_ssmtp.sh has configured ssmtp'
+grep -qc "$ConfiguredComment" /etc/ssmtp/ssmtp.conf && {
+    echo "smtp configured."
+    exit
+}
+
+sed -i \
+    -e "s/\(root=\).*\$/\1$SSMTP_ROOT/g" \
+    -e "s/\(mailhub=\).*\$/\1$SSMTP_MAILHUB/g" \
+    -e "s/\(hostname=\).*\$/\1$SSMTP_HOSTNAME/g" \
+    /etc/ssmtp/ssmtp.conf
+[ -z "$SSMTP_USE_STARTTLS" ] || echo "UseSTARTTLS=$SSMTP_USE_STARTTLS" >> /etc/ssmtp/ssmtp.conf
+[ -z "$SSMTP_AUTH_USER" ] || echo "AuthUser=$SSMTP_AUTH_USER" >> /etc/ssmtp/ssmtp.conf
+[ -z "$SSMTP_AUTH_PASS" ] || echo "AuthPass=$SSMTP_AUTH_PASS" >> /etc/ssmtp/ssmtp.conf
+[ -z "$SSMTP_AUTH_METHOD" ] || echo "AuthMethod=$SSMTP_AUTH_METHOD" >> /etc/ssmtp/ssmtp.conf
+[ -z "$SSMTP_FROMLINE_OVERRIDE" ] || echo "FromLineOverride=$SSMTP_FROMLINE_OVERRIDE" >> /etc/ssmtp/ssmtp.conf
+echo "$ConfiguredComment" >> /etc/ssmtp/ssmtp.conf